Allow specification of custom default file for finding-cfgs #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocm-ci-robot-0
added
reviewed/ok-to-test
ccwienk
requested changes
Mar 4, 2025
8R0WNI3
force-pushed
the
8R0WNI3-defaults-file
branch
from
3f940a3 to
746377a
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
8R0WNI3
force-pushed
the
8R0WNI3-defaults-file
branch
from
746377a to
3282542
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
8R0WNI3
force-pushed
the
8R0WNI3-defaults-file
branch
from
3282542 to
0162bcb
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
ccwienk
requested changes
Mar 6, 2025
There was a problem hiding this comment.
having an abstraction between configuration (findings-cfgs) and their respective sources seems like a good idea.
However, can we split the cfg for data-sources, from the "retriever"? More concretely-speaking, I would suggest to drop the retrieve-methods, and instead define a function (maybe following our lookup-pattern: a "findings-cfg-lookup" that will accept cfg-references and return resolved objects) or class.
8R0WNI3
force-pushed
the
8R0WNI3-defaults-file
branch
from
0162bcb to
40f70d3
Compare
ocm-ci-robot-0
added
the
reviewed/ok-to-test
ocm-ci-robot-0
removed
the
reviewed/ok-to-test
ccwienk
approved these changes
Mar 7, 2025
8R0WNI3
force-pushed
the
8R0WNI3-defaults-file
branch
from
40f70d3 to
e6306ed
Compare
ocm-ci-robot-0
added
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: