fix: update workflow to create MbedtlsSizeOf.kt file #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolosov-n
reviewed
Apr 17, 2024
akolosov-n
reviewed
Apr 17, 2024
.github/workflows/update-mbedtls.yml
Outdated
| @@ -37,6 +37,11 @@ jobs: | |||
| pull-requests: write | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - name: Compile mbedtls | |||
There was a problem hiding this comment.
Hmm. But then this step makes compile-mbedtls job redundant. Can we somehow reuse the outcome of the compile-mbedtls job?
There was a problem hiding this comment.
I don't think its redundant since the different platforms require unique configurations for running, maybe pass the .kt from the linux compiler as a separate artifact?
There was a problem hiding this comment.
Yes, let's better try this way.
|
Looks good, still lets test it |
JuhaPekkaa
force-pushed
the
fix-update-workflow
branch
from
08730b7 to
369dd6f
Compare
akolosov-n
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Workflow for updating mbedtls is missing
MbedtlsSizeOf.ktWhy?
The
compileMbedtlst.shscript to create the file is never executed in the instance where the PR is created, since the downloaded artifacts only contain the binaries.Solution:
Run the compile script to create theMbedtlsSizeOf.ktfile and then remove the binariesCreate a new artifact inside
compileMbedtlst.shand pass the file from there