fix(derive): BatchStream Past batch handling
#876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
|
is/will there be an action test covering this case? |
Not yet, but set a reminder to get one in once I'm back to work. |
clabby
force-pushed
the
cl/fix-span-hang
branch
2 times, most recently
from
8ddffe2 to
138032f
Compare
clabby
force-pushed
the
cl/fix-span-hang
branch
from
138032f to
80905bb
Compare
byteflyfunny
pushed a commit
to mantle-xyz/kona
that referenced
this pull request
Feb 14, 2025
* fix(derive): `BatchStream` Past batch handling * test
byteflyfunny
added a commit
to mantle-xyz/kona
that referenced
this pull request
Mar 4, 2025
* adjust kona code to support Mantle's current version - Updated kona-executor codebase to ensure compatibility with the latest Mantle version * feat: Add EigenDA as a new data source for retrieval * feature: Adjust derive code to adapt to the Mantle version. * feature: Adjust derive code to adapt to the Mantle version. * feat: adapt revm for mantle * feature: Adjust derive code to adapt to the Mantle version. * remove grpc request method for zkvm compile * add test; * update revm * add some errors type * pub use some types * Refactor code structure; update alloy package version; add new features. * change bin for proof * remove da_indexer * remove da_indexer * chore: Improve error handling messages for Eigen DA * add log info * add log info * add log info * add log info * add log info * add log info * fix bug in eigen da blob size * debug derive * debug derive * debug derive * debug derive * fix: set base_fee to None (#2) * build: remove useless deps * fix: Prior to Holocene activation, this base_fee should always be none * fix: use non problematic hashmap fns * Synchronize the latest remote repository code on the main branch; rebase the development branch onto the main branch. * feat(build): Adjust RV target - `riscv64g` -> `riscv64ima` (op-rs#868) * feat(build): `riscv64g` -> `riscv64ima` * turn off `ziscr`, `zfencei`, `zicntr`, `zihpm` * fmt * fix * fix(derive): `BatchStream` Past batch handling (op-rs#876) * fix(derive): `BatchStream` Past batch handling * test * feat(build): Bump `asterisc-builder` version (op-rs#879) * fix: op-rs rename (op-rs#883) * fix: op-rs rename * fix: justfile * chore: op-rs rename: * chore(derive): Test Ignoring EIP-7702 (op-rs#887) * fix: Small Spelling Issue (op-rs#893) * Move temporary error logs to lower level than WARN (op-rs#897) * chore: fix some typos in comment (op-rs#906) Signed-off-by: piguagua <piguagua@aliyun.com> * feat(driver): Multi-block derivation (op-rs#888) Co-authored-by: refcell <abigger87@gmail.com> * chore(executor): Remove `anyhow` dev-dependency (op-rs#937) * feat: use empty requests hash when isthmus enabled (op-rs#951) * feat: Derive Eq/Ord/Hash for (Archived) PreimageKey(Type) (op-rs#956) * feat: allow 7702 receipts after Isthmus active (op-rs#959) * feat: fill eip 7702 tx env with auth list (op-rs#958) Co-authored-by: refcell <abigger87@gmail.com> * feat(executor): EIP-2935 Syscall Support [ISTHMUS] (op-rs#963) * feat(executor): EIP-7251 Syscall Support [ISTHMUS] (op-rs#968) * chore(executor): TxEnv Stuffing (op-rs#970) * feat(client): EIP-2537 BLS12-381 Curve Precompile Acceleration (op-rs#960) Co-authored-by: clabby <ben@clab.by> * chore(executor): De-duplicate `TrieAccount` type (op-rs#977) * fix(executor): Removes EIP-7002 and EIP-7251 Pre-block Calls (op-rs#990) * feat(proof-sdk): Cleanup `Hint` API (op-rs#998) * feat(mpt): Copy-on-hash (op-rs#1001) * feat(host): Accelerate all BLS12-381 Precompiles (op-rs#1010) * chore(client): Dedup MSM Required Gas Fn (op-rs#1012) * chore(client): Precompile Run Macro (op-rs#1014) * feat(executor): Sort trie keys (op-rs#1016) * feat(ci): Remove support for features after MSRV (op-rs#1018) * update upstream kona with some cherry pick commit * implemente clear func in eigenda source * fix: deposit_receipt_version should be None (#6) * fix: deposit_receipt_version should be None * chore: cargo fmt * Mantle kona mpt verify (#7) * downgrade the version of crossbeam-channel * Integrated the adjusted Hokulea and rust-kzg-bn254. * Integrated the eigenda verify * Adjust the EigenDA blob saving method to temporarily use one-time saving. * Optimize EigenDA blob data caching and proof generation. * optimize log levels * feat: support 7702 && cargo fmt * fix decode blob data bug * change eigen da point file * update op-alloy * without verification for commitment * remove point file --------- Co-authored-by: PinelliaC <wylbzc4928@gmail.com> --------- Signed-off-by: piguagua <piguagua@aliyun.com> Co-authored-by: PinelliaC <wylbzc4928@gmail.com> Co-authored-by: clabby <ben@clab.by> Co-authored-by: refcell <abigger87@gmail.com> Co-authored-by: Serge Radinovich <47865535+sergerad@users.noreply.github.com> Co-authored-by: piguagua <piguagua@aliyun.com> Co-authored-by: Rami <2418646+hashcashier@users.noreply.github.com> Co-authored-by: Julian Meyer <julianmeyer2000@gmail.com> Co-authored-by: Julian Meyer <julian.meyer@coinbase.com> Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the handling of the
BatchValidity::Pastcondition. It's currently throwing a temporaryEof, but the desired behavior is to continue reading old batches until all past batches have been read, validated, and discarded due to their timestamp.