Add support for geojson #1147
Merged
Add support for geojson #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the tests are failing due to download issue from geofabrik: I'm not sure this is related to the changes I made... |
Full logs: https://github.com/onthegomap/planetiler/actions/runs/12809430105 |
msbarry
reviewed
Jan 16, 2025
| GeoJsonReader(String sourceName, Path input) { | ||
| super(sourceName); | ||
| store = new GeoJSONDataStore(input.toFile()); | ||
| layer = input.getFileName().toString().replaceAll("\\.geojson$", ""); |
There was a problem hiding this comment.
I could see these having a .json extension too - could we default with just removing the file extension?
Comment on lines
78
to
80
| SimpleFeature simpleFeature = SimpleFeature.create((Geometry) feature.getDefaultGeometry(), HashMap.newHashMap(feature.getProperties().size()), | ||
| sourceName, layer, id++); | ||
| feature.getProperties().forEach(property -> { |
There was a problem hiding this comment.
minor: extract var properties = feature.getProperties(); once in case it's doing anything expensive to compute the properties map.
Also you can omit the curly braces on forEach(property -> {
There was a problem hiding this comment.
Sure, I'll fix that.
Comment on lines
+68
to
+77
| <dependency> | ||
| <groupId>org.geotools</groupId> | ||
| <artifactId>gt-geojson</artifactId> | ||
| <version>${geotools.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.geotools</groupId> | ||
| <artifactId>gt-geojson-store</artifactId> | ||
| <version>${geotools.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
I see JTS already has a GeoJsonReader class. Geotools has some licensing issues so I'm trying to avoid adding new dependencies on it. But the JTS reader doesn't seem to handle properties at all so this might be the best one to start with...
There was a problem hiding this comment.
Yes, JTS is only for geometries, it doesn't handle feature and feature collection...
Geotools uses it under the hood...
There was a problem hiding this comment.
Does the geotools version automatically handle parsing/converting CRS of input geojson?
There was a problem hiding this comment.
No clue, probably not, it is very similar to shapefile, I belive, in terms of API.
There was a problem hiding this comment.
I have tried to play with the Crs object of the store in various way but it seems to always return WGS84 even if the file said otherwise.
I've opened a ticket here:
https://osgeo-org.atlassian.net/browse/GEOT-7705
This can be read from the file itself, but it seems hacky...
There was a problem hiding this comment.
Ok thanks! The jts version handles crs but not properties, and geotools version handles properties but not crs 🤦♂️ if there's just one crs defined for the entire object it wouldn't be too bad to read it out like jts does (https://github.com/locationtech/jts/blob/master/modules/io/common/src/main/java/org/locationtech/jts/io/geojson/GeoJsonReader.java#L445-L470), but we could also merge this version then handle crs and newline-delimited in a follow-up pr?
There was a problem hiding this comment.
Sure, I think this is a good addition as is. We can always improve in the future.
|
For people using newline geojson it should be an easy task to add the surrounding feature collection I hope before running planetiler. |
|
|
OK thanks! The main benefit of newline-delimited geojson is if the dataset is very large, it can be read line-by-line instead of loading the whole thing in memory. I could take a stab at auto-detecting which kind it is and handling newline-delimited variant in a followup PR... |
|
Looks good now! Thanks for adding! |
|
Great! Let me know when a new version with this is available. |
zstadler
added a commit
to zstadler/planetiler
that referenced
this pull request
Feb 8, 2025
Implemented in onthegomap#1147
msbarry
pushed a commit
that referenced
this pull request
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very similar to #413.
It uses geotools' geojson capabilities (very similar to shapefile).
I've added some minimal tests, I think it might be enough, but I'm not sure.
I was able to run the tests I added but I'm getting an error when running
mvn clean installon the entire project.Let me know if anything is missing.