fix text color changes inconsistently when entering edit mode

[spartan-vutrannguyen]

Description

• Fix text color changes inconsistently when entering edit mode
  Root cause:
• The DOUBLE_CLICK action uses the getElementAtLoc function, which already passes true to include the styles object.
• The ENTER action uses getDomElementByDomId, but it still needs to pass true to retrieve the styles object as well.

Related Issues

• fixes [bug][elements] Text color changes inconsistently when entering edit mode #1725

Type of Change

• Bug fix
• New feature
• Documentation update
• Release
• Refactor
• Other (please describe):

Testing

Screenshots (if applicable)

Screen.Recording.2025-04-14.at.17.52.54.mp4

Additional Notes

---

Important

Fix inconsistent text color change in edit mode by updating getDomElementByDomId call and handling null URLs in Image.tsx.

• Behavior:
  • Fix inconsistent text color change when entering edit mode by modifying getDomElementByDomId call in index.ts to include an additional parameter.
  • Ensure setSelectedImage(null) is called in Image.tsx when no URL is provided.
• Files:
  • index.ts: Update getDomElementByDomId call to include true parameter.
  • Image.tsx: Add else block to set selectedImage to null when url is not provided.

^{This description was created by for c4e1f3e. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to c4e1f3e in 33 seconds

More details

• Looked at 26 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. apps/studio/src/components/Modals/Settings/Site/Image.tsx:32

• Draft comment:
  Using 'setSelectedImage(null)' in the else branch ensures the state resets when url is absent. This is a clear and safe fix.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

2. apps/studio/src/lib/editor/engine/text/index.ts:148

• Draft comment:
  Passing the additional boolean argument (true) to getDomElementByDomId seems intentional to address the text color issue. Ensure the API expects this change.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

3. apps/studio/src/components/Modals/Settings/Site/Image.tsx:29

• Draft comment:
  Good fix resetting selectedImage to null if no URL is provided. This prevents stale image data from persisting when the URL changes.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

4. apps/studio/src/lib/editor/engine/text/index.ts:147

• Draft comment:
  Adding the second argument 'true' to getDomElementByDomId aligns with how getElementAtLoc is used. Ensure that the API change is intentional and consistent with expected behavior.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

Workflow ID: wflow_Gpv6VSvqH4zCUy5l

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.