Skip to content

Added the warning in the input chat that links wouldn't work #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SoloDevAbu
Copy link
Contributor

@SoloDevAbu SoloDevAbu commented Apr 13, 2025

Description

Provide a warning on the chat that link wouldn't work

Related Issues

fixes #1649

Screenshots

Screenshot from 2025-04-13 23-46-36


Important

Adds a warning in chat input about non-functional links and updates page duplication naming in PageTreeNode.tsx.

  • Behavior:
    • Adds a warning in the chat input placeholder that links (e.g., www.*****.com or https://) won't work in translation.json and messages/en.json.
    • Modifies handleDuplicate in PageTreeNode.tsx to append '1' to the base name when duplicating a page.
  • Localization:
    • Updates translation.json and messages/en.json to include the new placeholder text for chat input.

This description was created by Ellipsis for e0edcb6. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to e0edcb6 in 1 minute and 38 seconds

More details
  • Looked at 45 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 7 drafted comments based on config settings.
1. apps/web/client/messages/en.json:71
  • Draft comment:
    Typo: Use 'https://' instead of 'https:://' in the warning text.
  • Reason this comment was not posted:
    Marked as duplicate.
2. apps/studio/src/routes/editor/LayersPanel/Tree/PageTreeNode.tsx:76
  • Draft comment:
    The duplicate logic is simplistic. Consider handling cases where the original name already ends in a digit.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
3. apps/studio/src/locales/en/translation.json:71
  • Draft comment:
    Consider correcting the URL example: 'https:://' appears to be a typo. Likely should be 'https://'.
  • Reason this comment was not posted:
    Marked as duplicate.
4. apps/routes/editor/LayersPanel/Tree/PageTreeNode.tsx:78
  • Draft comment:
    The duplication logic simply appends '1' to the last path segment. Consider handling potential edge cases and name collisions.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
5. apps/web/client/messages/en.json:71
  • Draft comment:
    Same as above: 'https:://' in the placeholder looks like a typo. Should be 'https://' for clarity.
  • Reason this comment was not posted:
    Marked as duplicate.
6. apps/studio/src/locales/en/translation.json:71
  • Draft comment:
    Typo in the placeholder text: 'https:://' should be corrected to 'https://'.
  • Reason this comment was not posted:
    Marked as duplicate.
7. apps/web/client/messages/en.json:71
  • Draft comment:
    Typographical error: it looks like 'https:://' should be corrected to 'https://'.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_nR1KpJQzgv2nKotL


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Warn users that inputting links won't work
1 participant