Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BridgePermissions._setPermissions() event behavior #174

Open
wants to merge 1 commit into
base: flip-318
Choose a base branch
from

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Feb 25, 2025

Updating in response to feedback was raised during implementation


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (flip-318@53610ef). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             flip-318     #174   +/-   ##
===========================================
  Coverage            ?   87.35%           
===========================================
  Files               ?       18           
  Lines               ?     1020           
  Branches            ?        0           
===========================================
  Hits                ?      891           
  Misses              ?      129           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review February 25, 2025 19:27
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner February 25, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

3 participants