Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WalletConnect support #2133

Merged
merged 42 commits into from
Feb 21, 2025
Merged

Add WalletConnect support #2133

merged 42 commits into from
Feb 21, 2025

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Feb 12, 2025

Closes #2072 #2137 #2138

This implementation still has the following issues:

  • Authentication flickering
  • Flow Wallet Connector does not support WC (see 4a8d094)
  • Rare race condition when flow wallet is slow to inject where 2 wallets can sometimes appear. Addressing this likely requires some clever refactoring and should be done in a follow up PR as is a lower prio than basic functionality/alpha.

The current servicePlugin extensibility system is bound to requests instead of sessions, making persistence and robust lifecycle management difficult to implement. I converted this to use a UniversalProvider instead so that both FCL-WC & the Eth WC provider can rely on the same shared interface.

Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: c8cb07c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jribbink jribbink changed the base branch from master to feature/cross-vm February 12, 2025 21:32
@jribbink jribbink force-pushed the jribbink/wc-support branch from faab1d4 to 893cb66 Compare February 12, 2025 23:16
@jribbink jribbink changed the title Jribbink/wc support Add WalletConnect support Feb 20, 2025
@jribbink jribbink marked this pull request as ready for review February 21, 2025 00:50
@jribbink jribbink requested a review from a team as a code owner February 21, 2025 00:50
@jribbink jribbink merged commit b010de2 into feature/cross-vm Feb 21, 2025
1 check passed
@jribbink jribbink deleted the jribbink/wc-support branch February 21, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants