-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WalletConnect support #2133
Conversation
|
faab1d4
to
893cb66
Compare
Closes #2072 #2137 #2138
This implementation still has the following issues:
The current
servicePlugin
extensibility system is bound to requests instead of sessions, making persistence and robust lifecycle management difficult to implement. I converted this to use a UniversalProvider instead so that both FCL-WC & the Eth WC provider can rely on the same shared interface.