Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Compile boolean operators #3796

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 25, 2025

Work towards #3769

Description

  • Compile boolean logical operators and (&&) and or (||)
  • Add JumpIfTrue instruction

Same logic as the Java compiler


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz February 25, 2025 23:37
@turbolent turbolent self-assigned this Feb 25, 2025
@turbolent turbolent requested a review from SupunS as a code owner February 25, 2025 23:37
Base automatically changed from bastian/compile-conditional to feature/compiler February 25, 2025 23:37
@turbolent turbolent closed this Feb 25, 2025
@turbolent turbolent reopened this Feb 25, 2025
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 038a460
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent merged commit fb14722 into feature/compiler Feb 26, 2025
7 of 9 checks passed
@turbolent turbolent deleted the bastian/compile-boolean-operators branch February 26, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants