Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split array.go into smaller files and group related functions #508

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Split array.go into smaller files and group related functions #508

merged 1 commit into from
Feb 14, 2025

Conversation

fxamacker
Copy link
Member

Updates #464

This change makes the code easier to read and maintain.

This PR splits array.go into:

  • array_data_slab.go
  • array_data_slab_decode.go
  • array_data_slab_encode.go
  • array_extradata.go
  • array_iterator.go
  • array_metadata_slab.go
  • array_metadata_slab_decode.go
  • array_metadata_slab_encode.go
  • array_size_consts.go
  • array_slab.go
  • buffer.go

While at it, this PR also groups related functions together.

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker
Split array.go into multiple go files
f7e4135 
This change makes the code easier to read and maintain.

This commit splits array.go into:
- array_data_slab.go
- array_data_slab_decode.go
- array_data_slab_encode.go
- array_extradata.go
- array_iterator.go
- array_metadata_slab.go
- array_metadata_slab_decode.go
- array_metadata_slab_encode.go
- array_size_consts.go
- array_slab.go
- buffer.go

While at it, this commit also groups related functions together.
@fxamacker fxamacker self-assigned this Feb 13, 2025
@fxamacker fxamacker requested a review from turbolent as a code owner February 13, 2025 23:11
@fxamacker fxamacker changed the title Split array.go into multiple go files Split array.go into smaller files and group related functions Feb 14, 2025
turbolent
turbolent approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! I guess the code was just split up as-is, and there were no other changes?

@fxamacker
Copy link
Member Author

Nice refactor! I guess the code was just split up as-is, and there were no other changes?

@turbolent Yes, no other changes. The code was split up as is, and I also grouped related functions together in the same file for readability.

@fxamacker fxamacker merged commit 3ed954a into main Feb 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees

@fxamacker fxamacker

Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @turbolent