Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to Go 1.23 and golangci-lint 1.63.4 #507

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Bump to Go 1.23 and golangci-lint 1.63.4 #507

merged 1 commit into from
Feb 13, 2025

Conversation

fxamacker
Copy link
Member

@fxamacker fxamacker commented Feb 12, 2025 •
edited
Loading

Updates #464

Also updated .golangci.yml to replace deprecated exportloopref linter with copyloopvar (suggested by golangci-lint v1.63.4).

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker self-assigned this Feb 12, 2025
@fxamacker fxamacker requested a review from turbolent as a code owner February 12, 2025 23:11
@fxamacker fxamacker marked this pull request as draft February 12, 2025 23:13
@fxamacker fxamacker force-pushed the fxamacker/bump-go-version branch from 414b88f to 04751eb Compare February 12, 2025 23:15
@fxamacker fxamacker changed the base branch from fxamacker/refactor-smoke-tests to main February 13, 2025 00:00
@fxamacker fxamacker force-pushed the fxamacker/bump-go-version branch from 04751eb to 9f9e302 Compare February 13, 2025 00:02
@fxamacker fxamacker marked this pull request as ready for review February 13, 2025 02:31
@fxamacker fxamacker merged commit 49e57ec into main Feb 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees

@fxamacker fxamacker

Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @turbolent