New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use helper funcs to compute map byte sizes in tests #501

Merged

fxamacker merged 1 commit into main from fxamacker/add-test-util-funcs-to-compute-map-byte-size

Feb 12, 2025

Member

fxamacker commented Feb 6, 2025

Updates #464

This refactor simplifies tests and can reduce mistakes.

Targeted PR against main branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels


          Use helper funcs to compute map byte sizes in tests

b08becc

This refactor simplifies tests and can reduce mistakes.

fxamacker added the Technical Debt label

fxamacker self-assigned this

fxamacker requested a review from turbolent as a code owner

February 6, 2025 18:10

turbolent approved these changes

View reviewed changes

Member

turbolent left a comment

Nice cleanup!

fxamacker merged commit c1bb11d into main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels