Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use helper functions to compute array sizes in tests #500

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Use helper functions to compute array sizes in tests #500

merged 1 commit into from
Feb 5, 2025

Conversation

fxamacker
Copy link
Member

Updates #464

This refactor simplifies tests and can reduce mistakes.

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker
Use helper funcs to compute array byte sizes in tests
4b31817 
This refactor simplifies tests and can reduce mistakes.
@fxamacker fxamacker self-assigned this Feb 4, 2025
@fxamacker fxamacker requested a review from turbolent as a code owner February 4, 2025 14:38
@fxamacker fxamacker merged commit c272e02 into main Feb 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees

@fxamacker fxamacker

Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @turbolent