Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using unexported mutableValueNotifier in tests #499

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Avoid using unexported mutableValueNotifier in tests #499

merged 2 commits into from
Feb 4, 2025

Conversation

fxamacker
Copy link
Member

Updates #464

While at it, I moved some functions (which access unexported fields or functions) from utils_test.go to export_test.go.

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker self-assigned this Feb 3, 2025
@fxamacker fxamacker requested a review from turbolent as a code owner February 3, 2025 21:30
@fxamacker fxamacker merged commit d2df8f8 into main Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees

@fxamacker fxamacker

Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @turbolent