Remove nolint comments for linter we don't enable

This commit removes nolint:gosec comments that were added by mistake (because we don't enable that linter).
onflow · Mar 1, 2025 · 94bacbd · 94bacbd
1 parent a61261e
commit 94bacbd
Show file tree

Hide file tree

Showing 9 changed files with 261 additions and 261 deletions.
diff --git a/array_test.go b/array_test.go
diff --git a/array_wrappervalue_test.go b/array_wrappervalue_test.go
@@ -533,7 +533,7 @@ func TestArrayWrapperValueAppendAndModify(t *testing.T) {
 
 				// Retrieve and modify WrapperValue from array
 				for i := range expectedValues {
-					v, err := array.Get(uint64(i)) //nolint:gosec // integer overflow conversions (e.g. uint64 -> int (G115), etc.) are OK for tests
+					v, err := array.Get(uint64(i))
 					require.NoError(t, err)
 
 					expected := expectedValues[i]
@@ -645,7 +645,7 @@ func TestArrayWrapperValueInsertAndModify(t *testing.T) {
 
 				// Retrieve and modify WrapperValue from array
 				for i := range expectedValues {
-					v, err := array.Get(uint64(i)) //nolint:gosec // integer overflow conversions (e.g. uint64 -> int (G115), etc.) are OK for tests
+					v, err := array.Get(uint64(i))
 					require.NoError(t, err)
 
 					expected := expectedValues[i]
@@ -772,7 +772,7 @@ func TestArrayWrapperValueSetAndModify(t *testing.T) {
 
 				// Retrieve and modify WrapperValue from array
 				for i := range expectedValues {
-					v, err := array.Get(uint64(i)) //nolint:gosec // integer overflow conversions (e.g. uint64 -> int (G115), etc.) are OK for tests
+					v, err := array.Get(uint64(i))
 					require.NoError(t, err)
 
 					expected := expectedValues[i]
@@ -916,7 +916,7 @@ func TestArrayWrapperValueInsertAndRemove(t *testing.T) {
 						// Retrieve and modify WrapperValue from array
 						if needToModifyElement {
 							for i := range expectedValues {
-								v, err := array.Get(uint64(i)) //nolint:gosec // integer overflow conversions (e.g. uint64 -> int (G115), etc.) are OK for tests
+								v, err := array.Get(uint64(i))
 								require.NoError(t, err)
 
 								expected := expectedValues[i]
@@ -1096,7 +1096,7 @@ func TestArrayWrapperValueSetAndRemove(t *testing.T) {
 						// Retrieve and modify WrapperValue from array
 						if needToModifyElement {
 							for i := range expectedValues {
-								v, err := array.Get(uint64(i)) //nolint:gosec // integer overflow conversions (e.g. uint64 -> int (G115), etc.) are OK for tests
+								v, err := array.Get(uint64(i))
 								require.NoError(t, err)
 
 								expected := expectedValues[i]
@@ -1884,7 +1884,7 @@ func TestArrayWrapperValueModifyNewArrayAtLevel1(t *testing.T) {
 
 		actualArrayCount -= removeCount
 
-		removeIndex := getRandomArrayIndexes(r, array, int(removeCount)) //nolint:gosec // integer overflow conversions (e.g. uint64 -> int (G115), etc.) are OK for tests
+		removeIndex := getRandomArrayIndexes(r, array, int(removeCount))
 
 		sort.Sort(sort.Reverse(uint64Slice(removeIndex)))
 
@@ -1989,7 +1989,7 @@ func TestArrayWrapperValueModifyNewArrayAtLevel1(t *testing.T) {
 
 			index := getRandomArrayIndex(r, array)
 
-			testSetElementInArray(t, storage, array, int(index), v, expectedValues[index]) //nolint:gosec // integer overflow conversions (e.g. uint64 -> int (G115), etc.) are OK for tests
+			testSetElementInArray(t, storage, array, int(index), v, expectedValues[index])
 
 			expectedValues[index] = expected
 
@@ -2154,7 +2154,7 @@ func TestArrayWrapperValueModifyNewArrayAtLevel2(t *testing.T) {
 
 		actualArrayCount -= removeCount
 
-		removeIndex := getRandomArrayIndexes(r, array, int(removeCount)) //nolint:gosec // integer overflow conversions (e.g. uint64 -> int (G115), etc.) are OK for tests
+		removeIndex := getRandomArrayIndexes(r, array, int(removeCount))
 
 		sort.Sort(sort.Reverse(uint64Slice(removeIndex)))
 
@@ -2227,7 +2227,7 @@ func TestArrayWrapperValueModifyNewArrayAtLevel2(t *testing.T) {
 
 		// Remove more elements
 
-		for i := 1; i < int(removeCount); i++ { //nolint:gosec // integer overflow conversions (e.g. uint64 -> int (G115), etc.) are OK for tests
+		for i := 1; i < int(removeCount); i++ {
 			index := getRandomArrayIndex(r, array)
 
 			testRemoveElementFromArray(t, storage, array, index, expectedValues[index])
@@ -2444,7 +2444,7 @@ func TestArrayWrapperValueModifyNewArrayAtLevel3(t *testing.T) {
 
 		actualArrayCount -= removeCount
 
-		removeIndex := getRandomArrayIndexes(r, array, int(removeCount)) //nolint:gosec // integer overflow conversions (e.g. uint64 -> int (G115), etc.) are OK for tests
+		removeIndex := getRandomArrayIndexes(r, array, int(removeCount))
 
 		sort.Sort(sort.Reverse(uint64Slice(removeIndex)))
 
@@ -2945,7 +2945,7 @@ func testArrayMutableElementIndex(t *testing.T, v atree.Value) {
 }
 
 func testSetElementInArray(t *testing.T, storage atree.SlabStorage, array *atree.Array, index int, newValue atree.Value, expected atree.Value) {
-	existingStorable, err := array.Set(uint64(index), newValue) //nolint:gosec // integer overflow conversions (e.g. uint64 -> int (G115), etc.) are OK for tests
+	existingStorable, err := array.Set(uint64(index), newValue)
 	require.NoError(t, err)
 	require.NotNil(t, existingStorable)