Add style and columnWidth options to the ExcelOpenSpoutExporter
#368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 37 37
Lines 1000 1000
=======================================
Hits 947 947
Misses 53 53 ☔ View full report in Codecov by Sentry. |
This adds an extra option on `AbstractColumn` to configure options specific for an exporter. The available options are defined on the exporter using `DataTableExporterInterface::configureColumnOptions()`. The style option allows to set the OpenSpout cell style for a column. The columnWidth sets the column width in the Excel sheet.
mhvis
force-pushed
the
maarten-openspout-style
branch
from
b6ce426 to
24cc5b8
Compare
|
@NMe84 might also want to look at this change. And thnx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a suggestion for making the Excel export output a little bit configurable, using custom column styles and widths. This way, we can have a native Excel currency format for the output columns in the Excel file.
Thanks for your helpful e-mail last week 😃. And I fully agree that a currency column will probably never be able to satisfy everyone's specific requirements.
See commit message for details.