Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpoffice/phpspreadsheet to v2 #330

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

karstennilsen
Copy link
Contributor

  • Update dependency
  • Replace depricated function setCellValueByColumnAndRow
  • htmlHelper->toRichTextObject does not support null anymore, convert null to empty string

Improvement / replacement of #329

…l since HTMLHelper does not support it anymore
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (2c41aae) to head (989c450).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          36       36           
  Lines         956      956           
=======================================
  Hits          903      903           
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curry684 curry684 merged commit 3ef3fcf into omines:master Feb 24, 2024
11 checks passed
@curry684
Copy link
Member

Looks legit 👍

Keep in mind that this is technically a BC break and so will not be autoupdated without manually changing your dependency.

@curry684
Copy link
Member

Turns out your change doesn't break on v1 so we can support both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants