Fix depreciations #198
Merged
Fix depreciations #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
reviewed
Nov 12, 2020
| @@ -114,7 +114,6 @@ public function getResults(AdapterQuery $query): \Traversable | |||
|
|
|||
| foreach ($paginator->getIterator() as $result) { | |||
| yield $result; | |||
| $this->manager->detach($result); | |||
There was a problem hiding this comment.
Maybe we can replace detach by clear() ? to prevent PHP blows up see #175
|
I'll just bite the bullet and merge all - it's not like Doctrine will ever 'fix' the detach challenge on their end. Thanks! |
curry684
pushed a commit
that referenced
this pull request
Jan 20, 2021
* Fix Doctrine\ORM\EntityManager::detach depreciation * Fix Symfony\Component\HttpFoundation\InputBag::get depreciation * Fix Symfony\Component\HttpFoundation\JsonResponse::create depreciation (cherry picked from commit 5ccdc12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at fixing depreciations.
Each fixed depreciation is in a single commit so you can cherry pick them if you disagree with some changes (I'm thinking of the removal of
EntityManager::detach: #175 (comment))Details :
0373fb5 - Fix Doctrine\ORM\EntityManager::detach depreciation
Should we replace
$this->manager->detach($result);by$this->manager->clear();? See this.Or should the user use the array hydratation mode in case of memory issues?
46d3f9e - Fix Symfony\Component\HttpFoundation\InputBag::get depreciation
Use
allinstead ofgetto retrieve an array.f341b7a - Fix Symfony\Component\HttpFoundation\JsonResponse::create depreciation
Use the constructor instead.
There are two depreciations remaining :
I don't think it is possible to migrate now as this bundle supports PHPUnit 8.5.
Already aware of it :
datatables-bundle/tests/Functional/FunctionalTest.php
Lines 69 to 71 in 83e5774