Use trans() for proper locale fallback when using CDN languages #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense I think, but doesn't this also require an update to https://github.com/omines/datatables-bundle/blob/master/bin/update-translations to avoid it removing the |
|
@curry684 there's no need to update that script, because |
|
@shades684 whatcha think? |
|
@freezy-sk could you check why it breaks all tests? Master branch is passing right now (don't think it was when you started this). |
|
@curry684 I squashed and rebased but it's still failing on ocramius/package-versions |
|
Yep, started breaking again in |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jkabat mentioned in #136 that he uses fr_FR as locale. this update should fix this issue when cdn language is configured with supported locale, but used with defined region