Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap colormap in vispy object #10

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

joshmoore
Copy link
Member

@joshmoore joshmoore commented Aug 10, 2021

see: ome/ome-zarr-py@d79c393

Optionally wraps colormaps to support versions of ome-zarr-py before PR 91 as well as after.

cc: @will-moore

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #10 (4f08a72) into main (d7325e8) will decrease coverage by 0.34%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   89.14%   88.80%   -0.35%     
==========================================
  Files           3        3              
  Lines         129      134       +5     
==========================================
+ Hits          115      119       +4     
- Misses         14       15       +1     
Impacted Files Coverage Δ
napari_ome_zarr/_reader.py 78.94% <80.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7325e8...4f08a72. Read the comment docs.

@will-moore
Copy link
Member

Code looks good - makes sense with ome/ome-zarr-py@d79c393. 👍

@joshmoore
Copy link
Member Author

Thanks, guys. Do we want to try to get the paired PRs released before @constantinpape moves forward with v0.3? Are there any worries about cutting releases of those in terms of forwards/backwards compatibility?

@constantinpape
Copy link

Thanks, guys. Do we want to try to get the paired PRs released before @constantinpape moves forward with v0.3? Are there any worries about cutting releases of those in terms of forwards/backwards compatibility?

Sounds good! If we don't include ome/ome-zarr-py#89 in the release yet I don't foresee compatibility issues.

@joshmoore joshmoore merged commit ad22a1c into ome:main Aug 12, 2021
@joshmoore joshmoore deleted the colormap-change branch August 12, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants