OKTA-330325 Ensure primary authentication expiration is 5 minutes fro… #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriizhegurov-okta
requested review from
laura-rodriguez and
bryanapellanes-okta
bryanapellanes-okta
approved these changes
Oct 1, 2020
| @@ -30,7 +30,8 @@ public DefaultSerializer() | |||
| NullValueHandling = NullValueHandling.Ignore, | |||
| DefaultValueHandling = DefaultValueHandling.Ignore, | |||
| ContractResolver = new DefaultContractResolver(), | |||
| }; | |||
| DateParseHandling = DateParseHandling.DateTimeOffset, | |||
| }; | |||
There was a problem hiding this comment.
Nit-pick: Fix indentation.
laura-rodriguez
approved these changes
Oct 1, 2020
Merged
andriizhegurov-okta
deleted the
OKTA-330325-Ensure-primary-authentication-expiration-is-5-minutes-from-authentication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…m authentication
Issue #
https://oktainc.atlassian.net/browse/OKTA-330325
Fix #41 41
Code
Current behavior
json date strings are being converted to DateTime objects, timezone information is lost during subsequent =>String=>DateTimeOffset conversion.
Desired behavior
json date strings will be deserialized to DateTimeOffset objects, timezone information is preserved during String=>DateTimeOffset conversion.
Additional Context