Add support for passing custom user agent header. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertjd
reviewed
Apr 16, 2020
* Remove BasedTrustedOptions. * Update README.md.
robertjd
approved these changes
Apr 20, 2020
laura-rodriguez
deleted the
lr-add-support-for-passing-custom-user-agent
branch
This was referenced Apr 20, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Authn API reference the following methods can require devs to provide additional info via user-agent:
AuthenticateAsyncUnlockAccountAsyncForgotPasswordAsyncThese methods will explicitly have a
UserAgentproperty within the method's options.User-agent will be not be overwritten if it is provided.
Fixes OKTA-286335 and #27.
UPDATE: I had to make some changes related to Travis since the build was failing.