Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

V1.0.6 #19

Merged
merged 3 commits into from
Nov 27, 2017
Merged

V1.0.6 #19

merged 3 commits into from
Nov 27, 2017

Conversation

cfnelson
Copy link
Contributor

@cfnelson cfnelson commented Nov 27, 2017

Changes Made:

NOTE:

  • The fix implemented will ensure that any existing state that may exist on first page load is copied across when we use the replaceState in our logFirstPageLoad.
  • We should maybe think about using a different key in the state object. Currently we usereferrer, but it is possible this may cause some confusion to developers or potentially be overwritten. Maybe something like okg_auto_analytics_referrer would be more unique and distinguishable.

@rdickert
Copy link

LGTM

@cfnelson cfnelson merged commit 97db8d7 into master Nov 27, 2017
@cfnelson cfnelson deleted the v1.0.6 branch November 27, 2017 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants