Changes to contract CIDs (requires updating the chel command) #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
multiformats/multicodec#369 merged |
…ing-malicious-contracts-from-being-loaded
…ing-malicious-contracts-from-being-loaded
…ing-malicious-contracts-from-being-loaded
…ing-malicious-contracts-from-being-loaded
…ing-malicious-contracts-from-being-loaded
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
corrideat
force-pushed
the
2115-investigate-potential-ways-of-preventing-malicious-contracts-from-being-loaded
branch
from
36d8709 to
942d1cb
Compare
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
2115-investigate-potential-ways-of-preventing-malicious-contracts-from-being-loaded
|
| Run status |
|
| Run duration | 11m 43s |
| Commit |
|
| Committer | Ricardo Iván Vieitez Parra |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
114
|
| View all changes introduced in this branch ↗︎ | |
taoeffect
reviewed
Jan 20, 2025
…ing-malicious-contracts-from-being-loaded
…ing-malicious-contracts-from-being-loaded
…ing-malicious-contracts-from-being-loaded
corrideat
force-pushed
the
2115-investigate-potential-ways-of-preventing-malicious-contracts-from-being-loaded
branch
from
7fdc3f7 to
6b02beb
Compare
…ing-malicious-contracts-from-being-loaded
corrideat
force-pushed
the
2115-investigate-potential-ways-of-preventing-malicious-contracts-from-being-loaded
branch
from
6e6cd09 to
daef9a9
Compare
…ing-malicious-contracts-from-being-loaded
taoeffect
reviewed
Feb 25, 2025
shared/domains/chelonia/utils.js
Outdated
Comment on lines
852
to
856
| export const CONTRACT_MANIFEST_REGEX: RegExp = /^zL7mM9d4Xb4T[123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz]{44}$/ | ||
| export const CONTRACT_SOURCE_REGEX: RegExp = /^zLAeVmpcc88g[123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz]{44}$/ | ||
| export const CONTRACT_DATA_REGEX: RegExp = /^zLDXeQ2AgfCu[123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz]{44}$/ | ||
| export const FILE_MANIFEST_REGEX: RegExp = /^zLGQo2DimCH8{44}$/ | ||
| export const FILE_CHUNK_REGEX: RegExp = /^zLKHweRGqjMM{44}$/ |
There was a problem hiding this comment.
Why are the last two missing [123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz]?
taoeffect
reviewed
Feb 25, 2025
Gruntfile.js
Outdated
Comment on lines
267
to
269
| // This banner makes contracts easy to detect and harmless in the event | ||
| // of accidental execution | ||
| js: 'for(;;)"use shelter";' |
There was a problem hiding this comment.
Please update this comment to say that the reason this is being added is to prevent people from uploading malicious contracts to our servers and then loading them elsewhere (e.g. via XSS or whatever).
EDIT: however, this isn't enforced server side, so it seems there's no point to it.
IMO, unless it's enforced server-side, we shouldn't have this as it's unnecessary complexity that accomplishes nothing. And if we enforce it server-side, then we can't support other languages — something we want.
So please could you remove this banner and related code?
…ing-malicious-contracts-from-being-loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will probably fail until the
chelcommand is updated. See https://github.com/okTurtles/chel/compare/1927-design-implement-contract-deletion-op_contract_delete-1.