Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wide code snippets in chat don't display correctly #2243

Closed
taoeffect opened this issue Jul 21, 2024 · 5 comments
Closed

Wide code snippets in chat don't display correctly #2243

taoeffect opened this issue Jul 21, 2024 · 5 comments
Assignees
@SebinSong
Labels
App:Frontend Kind:Bug Level:Starter Note:UI/UX Priority:High

Comments

@taoeffect
Copy link
Member

Problem

Screenshot 2024-07-20 at 6 28 34 PM

Notice how it's going off and to the right past the scrollbar in the chatroom.

Solution

  • The code block should be inside of a div that has a maximum width that expands to the side of the chat container.
  • When text goes beyond that width, a horizontal scrollbar should appear at the bottom of the codeblock (don't wrap the text, in other words)
@SebinSong SebinSong mentioned this issue Jul 23, 2024
Merged
SebinSong added a commit that referenced this issue Jul 23, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2243-wi…
0b7713d 
…de-code-snippet-issue
@Silver-IT
Copy link
Member

Silver-IT commented Jul 23, 2024 •
edited
Loading

Also for the pinned messages too.
image

EDITED: Fine to skip this error in this issue. Since it's added to another issue #2250

@SebinSong
Copy link
Collaborator

SebinSong commented Jul 24, 2024 •
edited
Loading

@Silver-IT go ahead and open an issue / work on them yourself.

(EDIT: I actually fixed it myself)

@SebinSong SebinSong self-assigned this Jul 24, 2024
@Silver-IT
Copy link
Member

Okay, I added the issues in #2250.

taoeffect pushed a commit that referenced this issue Jul 24, 2024
@SebinSong
#2243 - Fix markdown <code> element issue (#2247)
6380d4d 
* fix the markdown issue

* display horizontal scrollbar instead

* flaky test

* fix the overflowing emojis

* flaky test
@SebinSong
Copy link
Collaborator

@Silver-IT I actually fixed it as part of the ongoing PR. So, no worries. (And good catch 👍)

@SebinSong
Copy link
Collaborator

Issue resolved in #2247 . closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebinSong SebinSong

Labels
App:Frontend Kind:Bug Level:Starter Note:UI/UX Priority:High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@taoeffect @SebinSong @Silver-IT