fabtests/common: Set the min of tx/rx_mr_size #10819
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aingerson
reviewed
Feb 22, 2025
In FT_OPT_ALLOC_MULT_MR mode, currently tx/rx_mr_size is set as the opts.transfer_size, and the subsequent ft_alloc_ctx_array will use this size to allocate tx/rx buffers in the ctx array. However, when test call ft_post_rx_buf, it will finally post a size as MAX(opts.transfer_size, FT_MAX_CTRL_MSG). When opts.transfer_size is smaller than FT_MAX_CTRL_MSG, it will cause test call fi_recv of size larger than the actual buffer (and MR) size and cause error when the provider offload the recv directly to hardware. This patch fixes this issue by making the tx/rx_mr_size has a min value as the FT_MAX_CTRL_MSG. Signed-off-by: Shi Jin <sjina@amazon.com>
|
@shijin-aws Please hold on merging. CI failed fabtests stages for multiple providers. Our cluster is having issues so I need to figure out if it had anything to do with the changes or if it was the cluster was in a bad state. |
|
@aingerson @zachdworkin any update on the Intel CI failure? |
|
@shijin-aws our CI cluster is having node issues. We are resolving them and will run ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FT_OPT_ALLOC_MULT_MR mode, currently tx/rx_mr_size is set as the opts.transfer_size, and the subsequent ft_alloc_ctx_array will use this size to allocate
tx/rx buffers in the ctx array.
However, when test call ft_post_rx_buf, it will
finally post a size as MAX(opts.transfer_size, FT_MAX_CTRL_MSG). When opts.transfer_size is smaller than FT_MAX_CTRL_MSG, it will cause test call fi_recv of size larger than the actual buffer (and MR) size and cause error when the provider offload the recv directly to hardware.
This patch fixes this issue by making the tx/rx_mr_size has a min value as the FT_MAX_CTRL_MSG.