[v1.21.x] Intel/CI: Cherrypick CI updates #10754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdworkin
previously approved these changes
Jan 31, 2025
Juee14Desai
force-pushed
the
v1.21.x
branch
2 times, most recently
from
c1dd595 to
68d9bfb
Compare
Instead of running a single stage, separated the stages to run different providers on different partitions Signed-off-by: Juee Himalbhai Desai <juee.himalbhai.desai@intel.com>
Signed-off-by: Juee Himalbhai Desai <juee.himalbhai.desai@intel.com>
Signed-off-by: Zach Dworkin <zachary.dworkin@intel.com>
Signed-off-by: Juee Himalbhai Desai <juee.himalbhai.desai@intel.com>
zachdworkin
previously approved these changes
Feb 6, 2025
The '-' in the xfer-method option in the runmultinode.sh script causes
method and xfer as separate instead of a single bash variable xfer-method.
This supplies invalid inputs to the fi_multinode test. changing the bash variable xfer-method
to xfer_method fixes this issue.
Signed-off-by: Juee Himalbhai Desai <juee.himalbhai.desai@intel.com>
Currently no way exists to specify env variables to the multinode scripts. Added option to runmultinode.sh. Changes similar to runfabtests.sh Signed-off-by: Nikhil Nanal <nikhil.nanal@intel.com>
Signed-off-by: Juee Himalbhai Desai <juee.himalbhai.desai@intel.com>
Signed-off-by: Nikhil Nanal <nikhil.nanal@intel.com>
zachdworkin
previously approved these changes
Feb 14, 2025
|
Can you update the name to be [v1.21.x] Intel/CI: Cherrypick CI updates and then elaborate what they are in the description? |
Juee14Desai
changed the title
Made a few updates to the multinode test:
1. accept a -x flag to turn off setting the service/node/flags
- this is needed to work with CXI
2. accept a -u flag to set a process manager: pmi or pmix
3. modify the code to get the rank from the appropriate environment
variable if a process manager is specified.
4. Add a runmultinode.py script which enables users to run the test
using a backing process manager. The python script takes a YAML
configuration file which defines the environment and test. An example
python configuration file:
multinode:
environment:
FI_MR_CACHE_MAX_SIZE: -1
FI_MR_CACHE_MAX_COUNT: 524288
FI_SHM_USE_XPMEM: 1
FI_LOG_LEVEL: info
bind-to: core
map-by-count: 1
map-by: l3cache
pattern: full_mesh
Script Usage:
usage: runmultinode.py [-h] [--dry-run] [--ci CI] [-C CAPABILITY]
[-i ITERATIONS] [-l {internal,srun,mpirun}]
[-p PROVIDER] [-np NUM_PROCS] [-c CONFIG]
[-t PROCS_PER_NODE]
libfabric multinode test with slurm
optional arguments:
-h, --help show this help message and exit
--dry-run Perform a dry run without making any changes.
--ci CI Commands to prepend to test call. Only used with the
internal launcher option
-C CAPABILITY, --capability CAPABILITY
libfabric capability
-i ITERATIONS, --iterations ITERATIONS
Number of iterations
-l {internal,srun,mpirun}, --launcher {internal,srun,mpirun}
launcher to use for running job. If nothing is
specified, test manages processes internally.
Available options: internal, srun and mpirun
Required arguments:
-p PROVIDER, --provider PROVIDER
libfabric provider
-np NUM_PROCS, --num-procs NUM_PROCS
Map process by node, l3cache, etc
-c CONFIG, --config CONFIG
Test configuration
Required if using srun:
-t PROCS_PER_NODE, --procs-per-node PROCS_PER_NODE
Number of procs per node
Running the script:
runmultinode.py -p cxi -i 1 --procs-per-node 8 --num-procs 8 -l srun -c mn.yaml
Signed-off-by: Amir Shehata <shehataa@ornl.gov>
ubertest implementation currently requires FI_RMA_EVENT when using RMA and counters This will cause tcp to return ENODATA for these combinations and cause runfabtests to fail. This should get updated in ubertest to not require it but remove testing for now Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
Update arguments to avoid conflicts with other tests. Signed-off-by: Alex McKinley <alex.mckinley@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the oneccl CPU and separate it to use different partitions.