top menu visibility options and top menu color #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ some cleaning + test
Rewrite `AddElementOption` and `SpacingOption` to be compatible with masonry snipet Implement `AddElementOption` button functionalities
At some point, servers started to return `image/svg+xml; charset=utf-8` instead of `image/svg+xml` in the `content-type` header of SVG images. Because of this, dynamic SVGs were not properly handled anymore. This commit adapts the mimetype comparisons to cope for this extra `charset` info inside the mimetype. Steps to reproduce: - Drop an image block inside a website page. - Replace the image. - Search for e.g. "city". - Pick an undraw illustration. => The image was lost because its `src` became `false`. closes odoo#199112 X-original-commit: e255894 Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
before colors change weren't taken into account and where sent everytime the PositionValue was "overTheContent" even with no change
duau-odoo
changed the title
fdardenne
reviewed
Mar 7, 2025
addons/html_builder/static/src/plugins/top_menu_visibility_option_plugin.js
Show resolved
Hide resolved
addons/html_builder/static/src/plugins/top_menu_visibility_option_plugin.js
Show resolved
Hide resolved
robinlej
reviewed
Mar 7, 2025
| @@ -0,0 +1,22 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
About your commits: you can squash them all (see git rebase -i if you don't know how)
Note: as master-mysterious-egg is a working branch, we don't care too much about the commit wording, but we still try to have meaningful commits (meaning, 1) the code of each commit should make sense in itself, 2) group things that are linked in the same commit, 3) if 2 features have no link, it may be worth doing a separate commit, but most of the time 1 commit is enough)
addons/html_builder/static/src/plugins/top_menu_visibility_option_plugin.js
Show resolved
Hide resolved
ged-odoo
force-pushed
the
master-mysterious-egg
branch
from
b651514 to
9236e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.