image_gallery option: implement columns #4155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename masonry_item_option to vertical_justify_option to make it more general and use it for the option with selector '.s_quadrant .o_grid_item'
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
The option was duplicated in the section of the carousel (in addition to be in the slide's section)
Before this commit, svg for the shadow option were invisible. This commits restore the colors of the svg buttons.
Before this commit, the start and end of the input range were not reachable due to its styling. Now, this issue is resolved, improving usability.
Firefox records a mutation when the textContent of an element is assigned to the same value as before, but Chrome doesn't. This leads to the builder marking many elements as dirty as soon as a single modification is done. This commit is a quick fix for the observed errors. A deeper fix should come with task-4629669.
This commit adds the option to move the order of an image in the image gallery It removes the old "notify" system to handle the reorder command, but uses dispatching and a name parameter to decide who should handle the reordering
The `AddSnippetDialo`g component is doing a `loadBundle` to fetch the content to put in the snippet dialog. Previously, when using the `AddSnippetDialog``, tests waited for a arbitrary amount of time before the snippet dialog shows. This resulted in tests failing when there is latency from the server/network. This commit adds an utility that allow us to await the loadBundle used by `AddSnippetDialog`allowing the tests to not wait an arbitrary amount of time.
With this commit, the user can now change the columns in image galleries. The columns can be changed in the grid and the masonry layout.
fdardenne
force-pushed
the
mysterious-egg-dafl-2
branch
from
bc94e7f to
68ff9b7
Compare
ged-odoo
force-pushed
the
master-mysterious-egg
branch
from
b651514 to
9236e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, the user can now change the columns
in image galleries. The columns can be changed in
the grid and the masonry layout.