CookiesBarOption #4070
Open
CookiesBarOption #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `contains(selector).click()` intead of `click` + `animationFrame`
- Creation of device visibility option. - Creation of the CommonBetweenOptions plugin that replaces the common methods of the `SnippetEditor`. In this context, it handles any `clean_for_save_handlers` that an option could have by calling the appropriate method on the appropriate element (depending on the selector and the exclude of the option).
The goal of this PR is to create a hook that makes it easy to display a ColorPicker. Now, to open a ColorPicker, you need to call useColorPicker with the ref of the target and a function to get props when you open it. Since this PR, the ColorPicker refers to the popover with the 3 tabs (solid, custom and gradient). The old ColorPicker component is renamed CustomColorPicker.
- start interactions on snippet added / replaced - stop interactions on snippet removed - move the initial start of interactions when launching edit into the new plugin Unrelated: - delete preview parts of snippets in the AddSnippetDialog after validating a new snippet.
robinlej
force-pushed
the
master-mysterious-egg-role-2
branch
from
6e12503 to
0164ffc
Compare
ged-odoo
force-pushed
the
master-mysterious-egg
branch
from
b651514 to
9236e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.