Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP avoid "Maximum call stack size exceeded" errors #598

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,29 @@ export function throttling(octokit: Octokit, octokitOptions: OctokitOptions) {
const events = {};
const emitter = new Bottleneck.Events(events);
// @ts-expect-error
events.on("secondary-limit", state.onSecondaryRateLimit);
events.on("secondary-limit", async (...args) => {
try {
// @ts-expect-error
return await state.onSecondaryRateLimit(...args);
} catch (error) {
// avoid "Maximum call stack size exceeded" error
setTimeout(() => {
throw error;
});
}
});
// @ts-expect-error
events.on("rate-limit", state.onRateLimit);
events.on("rate-limit", async (...args) => {
try {
// @ts-expect-error
return await state.onRateLimit(...args);
} catch (error) {
// avoid "Maximum call stack size exceeded" error
setTimeout(() => {
throw error;
});
}
});
// @ts-expect-error
events.on("error", (e) =>
octokit.log.warn("Error in throttling-plugin limit handler", e)
Expand Down