Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced cdn.pika.dev with cdn.skypack.dev in README #101 #105

Closed
wants to merge 1 commit into from
Closed

Replaced cdn.pika.dev with cdn.skypack.dev in README #101 #105

wants to merge 1 commit into from

Conversation

nk183
Copy link
Contributor

@nk183 nk183 commented Oct 16, 2020

Fixed #101

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thank you! We will merge your changes shortly, together with other pull requests that address the same issue. We also added the hacktoberfest-accepted label so your pull request counts already, in case you are participating.

@gr2m
Copy link
Contributor

gr2m commented Oct 17, 2020

@nk183 small nit: your pull request description

Fixed issue #101

Doesn't work to automatically close #101 when this pull request gets merged. I've changed it to

Fixed #101

That will work. GitHub is rather particular about these special words. You can learn more about these at https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m
Copy link
Contributor

gr2m commented Oct 23, 2020

Congratulations 🥳 We hope you enjoyed the process of sending the pull requests, and maybe learned a thing or two? If anything was unclear, or if you have any suggestions on how we can improve the suggestions in the issue #123, please let us know! It will help future first time contributors!

If you are looking to make another pull requests, look out for issues with the help wanted label. They are not as straight forward as the first-timers-only issues, but hey, you no longer are a first-timers 🙂 You can find help wanted issues here.

You can help us by starring this repository, as well as our primary repository at https://github.com/octokit/rest.js/ ⭐️ Stars help others to discover our project.

If you are interested in Octokit and future opportunities to contribute, you can subscribe to our announcement discussion at https://github.com/octokit/rest.js/discussions/620. We will post and update soon and will point out issues you can contribute to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README
3 participants