Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(linux): fix deb package file permissions #627

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

Palakis
Copy link
Contributor

@Palakis Palakis commented Dec 7, 2020

Description

Files in the Debian/Ubuntu package are all chmod'ed to 777 (read/write to everyone). This shouldn't be the case.

Motivation and Context

Fixes #620

How Has This Been Tested?

Checking permissions by reading the generate Debian package with 7-Zip on Windows 10.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Palakis Palakis self-assigned this Dec 7, 2020
@Palakis Palakis added the bug label Dec 7, 2020
@Palakis Palakis added this to the 4.9 milestone Dec 7, 2020
@Palakis Palakis force-pushed the bugfix/deb-file-permissions branch 2 times, most recently from 82d9389 to 34a28b8 Compare December 7, 2020 10:21
@tt2468 tt2468 force-pushed the bugfix/deb-file-permissions branch 3 times, most recently from ffeca0a to 5299acd Compare December 20, 2020 06:41
@tt2468 tt2468 force-pushed the bugfix/deb-file-permissions branch from 5299acd to 501e0f6 Compare December 20, 2020 06:54
@tt2468 tt2468 marked this pull request as ready for review December 20, 2020 06:55
@tt2468 tt2468 merged commit 7ae016b into 4.x-current Dec 20, 2020
@tt2468 tt2468 deleted the bugfix/deb-file-permissions branch December 20, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

obs-websocket-4.8.0-1_amd64.deb contains files with mode 777
2 participants