Don't loop CEF exit while shutting down if task post fails #476
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes a while loop which loops infinitely if posting the shutdown task to the manager thread fails. In scenarios where Cef failed to initialize, this manager thread exits early, leaving a situation where tasks cannot be posted to it. In normal scenarios, posting the task is not expected to fail anyway.
This also logs a debug message just in case it becomes relevant in the future.
Motivation and Context
If the
manager_thread
exits early, there will be no message loop to post the task to, and a permanent deadlock would occur.Rather than guaranteeing a deadlock, this at least lowers the odds of one.
How Has This Been Tested?
All test scenarios exited gracefully without deadlocking.
Types of changes
Checklist: