only identity if all values are colors #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
added a commit
that referenced
this pull request
Jan 18, 2022
* automatic color identity scale * only identity if all values are colors (#676) * only identity if all values are colors * comments * don’t use identity if scheme or range * comments on scale type inference * DRY * Update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amendment to #673 and alternative to #660 and #675. I think this is my preference because it feels more semantic than using an ordinal scale (even though this means you won’t get a legend, but I don’t think you want a legend for an identity scale). And unlike #673 alone this will reduce the likelihood of false positives since all defined values must be valid CSS colors. That’s a bit more strict than we usually do, but I think it’s okay since there isn’t a special type for colors and hence we must test strings.