-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symbol #652
symbol #652
Conversation
c1005c1
to
ea08e4d
Compare
I like where this is going. We can do the legend (a bit) later; I need to revisit the radius legend also… |
wow! |
The adoption of new (preattentive) symbols is probably a blocker for this PR, unless we can come up with good and non-conflicting names for those symbols. I wouldn’t want people to have to say |
Re: symbols names, just like you can have text: "abc" and various fonts, we could imagine that symbol: "diamond" looks up the diamond symbol in the current symbolFamily / symbolSet. (In other words I don't believe there can be a flat namespace for symbols, see the unicode/emoji mess.) This approach would also allow "styling", by switching to a different symbol set. It would be cool to systematically have the symbols aliased as symbol1 symbol2 symbol3, on top of their descriptive names. |
I would prefer symbol names that are context-free so that it’s unambiguous and you can mix and match symbols from different sets. Also, I’d generally like Plot to use D3’s names simply to avoid introducing confusion, and we’ll need to pick unique names for D3 (in d3/d3-shape#189, currently: asterisk, diamond2, plus, square2, triangle2, and x). It’ll also be possible to say I can start prototyping this here but it’d probably be easier to land and release the new d3-shape first, once you review. |
b720e62
to
f2eda5b
Compare
18559aa
to
3daa852
Compare
41701bd
to
3a5b92a
Compare
* vector * default anchor to middle * remove blank lines * further code golf * symbol (#652) * symbol * optimize rendering * maybeSymbolChannel * move default symbol to Plot.Dot * symbol legend * symbol legend paint options * color+symbol legend * automatic symbol hints * fix for orthogonal color and symbol * preattentive symbols * update README * remove vectorX, vectorY * update README * length scale * Update README * limit max default vector length to 60px * fix y-only symbols * Update README.md Co-authored-by: Philippe Rivière <fil@rezo.net> * Update README * update README Co-authored-by: Philippe Rivière <fil@rezo.net>
TODO
Fixes #41.