Update Zookeeper to gain parity with google #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirianni
requested changes
Mar 3, 2022
There was a problem hiding this comment.
I get regex errors with the following
log
2022-01-31 17:51:45,451 - INFO [NIOWorkerThread-3:NIOServerCnxn@514] - Processing mntr command from /0:0:0:0:0:0:0:1:50284
2022-01-31 17:51:45,451 [myid:1] - INFO [NIOWorkerThread-3:NIOServerCnxn@514] - Processing mntr command from /0:0:0:0:0:0:0:1:50284
2022-01-31 17:51:45,451 - INFO [NIOWorkerThread-3:NIOServerCnxn@514] - Processing mntr command from /0:0:0:0:0:0:0:1:50284
2022-01-31 17:51:45,451 [myid:1] - INFO [NIOWorkerThread-3:NIOServerCnxn@514] - Processing mntr command from /0:0:0:0:0:0:0:1:50284
2022-01-31 17:51:45,451 - INFO [NIOWorkerThread-3:NIOServerCnxn@514] - Processing mntr command from /0:0:0:0:0:0:0:1:50284
2022-01-31 17:51:45,451 [myid:1] - INFO [NIOWorkerThread-3:NIOServerCnxn@514] - Processing mntr command from /0:0:0:0:0:0:0:1:50284
2022-02-01 00:46:33,626 - WARN [SendWorker:2:QuorumCnxManager$SendWorker@1283] - Interrupted while waiting for message on queue
java.lang.InterruptedException
at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:2056)
at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2133)
at org.apache.zookeeper.util.CircularBlockingQueue.poll(CircularBlockingQueue.java:105)
at org.apache.zookeeper.server.quorum.QuorumCnxManager.pollSendQueue(QuorumCnxManager.java:1448)
at org.apache.zookeeper.server.quorum.QuorumCnxManager.access$900(QuorumCnxManager.java:99)
at org.apache.zookeeper.server.quorum.QuorumCnxManager$SendWorker.run(QuorumCnxManager.java:1272)
2022-01-31 17:51:45,451 [myid:1] - INFO [NIOWorkerThread-3:NIOServerCnxn@514] - Processing mntr command from /0:0:0:0:0:0:0:1:50284
Config
pipeline:
- type: zookeeper
file_path: ./in
start_at: beginning
- type: stdout
This comment was marked as outdated.
This comment was marked as outdated.
|
Updated to support multiple files. |
jsirianni
reviewed
Mar 29, 2022
Comment on lines
+10
to
+11
| - "/opt/zookeeper/logs/zookeeper-*.out" | ||
| - "/var/log/zookeeper/zookeeper.log" |
There was a problem hiding this comment.
Are these the same default values as ops-agent? Generally, if zookeeper is writing logs to one, it will not be writing to the other.
In my opinion, we keep the default the same.
There was a problem hiding this comment.
yeah, these are the default paths that are looked for in the ops-agent .
When you say keep the default the same, you are talking about "/home/kafka/kafka/logs/zookeeper.log" and then the user would have to specify one ops-agent path or the other?
| description: The absolute path to the Zookeeper logs | ||
| type: string | ||
| default: "/home/kafka/kafka/logs/zookeeper.log" | ||
| type: strings |
There was a problem hiding this comment.
I like the idea of using strings here, but it does break compatibility. I am okay with this.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to support multiple files.
The new multi-file Config
2 examples(first single line, second multiline) with ID is sent to zookeeper.log
And results in json
{ "timestamp": "2022-03-28T13:57:00.535062-04:00", "severity": 30, "severity_text": "INFO", "labels": { "file_name": "zookeeper.log", "plugin_id": "zookeeper" }, "record": { "line": "514", "message": "Processing mntr command from /0:0:0:0:0:0:0:1:50284\n\n\n", "myid": "1", "source": "NIOServerCnxn", "thread": "NIOWorkerThread-3", "time": "2022-01-31 17:51:45,451" } } { "timestamp": "2022-03-28T13:57:08.135142-04:00", "severity": 50, "severity_text": "WARN", "labels": { "file_name": "zookeeper.log", "plugin_id": "zookeeper" }, "record": { "line": "1283", "message": "Interrupted while waiting for message on queue\njava.lang.InterruptedException\n\tat java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:2056)\n\tat java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2133)\n\tat org.apache.zookeeper.util.CircularBlockingQueue.poll(CircularBlockingQueue.java:105)\n\tat org.apache.zookeeper.server.quorum.QuorumCnxManager.pollSendQueue(QuorumCnxManager.java:1448)\n\tat org.apache.zookeeper.server.quorum.QuorumCnxManager.access$900(QuorumCnxManager.java:99)\n\tat org.apache.zookeeper.server.quorum.QuorumCnxManager$SendWorker.run(QuorumCnxManager.java:1272)\n", "myid": "1", "source": "QuorumCnxManager$SendWorker", "thread": "SendWorker:2", "time": "2022-02-01 00:46:33,626" } }2 examples(first single line, second multiline) without ID is sent to zookeeper2.log
and results in json
{ "timestamp": "2022-03-28T13:57:41.33453-04:00", "severity": 30, "severity_text": "INFO", "labels": { "file_name": "zookeeper2.log", "plugin_id": "zookeeper" }, "record": { "line": "514", "message": "Processing mntr command from /0:0:0:0:0:0:0:1:50284\n\n", "source": "NIOServerCnxn", "thread": "NIOWorkerThread-3", "time": "2022-01-31 17:51:45,451" } } { "timestamp": "2022-03-28T13:57:54.335323-04:00", "severity": 50, "severity_text": "WARN", "labels": { "file_name": "zookeeper2.log", "plugin_id": "zookeeper" }, "record": { "line": "1283", "message": "Interrupted while waiting for message on queue\njava.lang.InterruptedException\n\tat java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:2056)\n\tat java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2133)\n\tat org.apache.zookeeper.util.CircularBlockingQueue.poll(CircularBlockingQueue.java:105)\n\tat org.apache.zookeeper.server.quorum.QuorumCnxManager.pollSendQueue(QuorumCnxManager.java:1448)\n\tat org.apache.zookeeper.server.quorum.QuorumCnxManager.access$900(QuorumCnxManager.java:99)\n\tat org.apache.zookeeper.server.quorum.QuorumCnxManager$SendWorker.run(QuorumCnxManager.java:1272)\n", "source": "QuorumCnxManager$SendWorker", "thread": "SendWorker:2", "time": "2022-02-01 00:46:33,626" } }