Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use enum for tls min version. fix friendly name #372

Merged
merged 2 commits into from
Oct 15, 2021
Merged

use enum for tls min version. fix friendly name #372

merged 2 commits into from
Oct 15, 2021

Conversation

jsirianni
Copy link
Member

  • Fix http input label
  • Use enum instead of string for min tls version, we know the valid values so we should enforce them

@jsirianni jsirianni requested a review from schmikei October 15, 2021 15:20
@jsirianni
Copy link
Member Author

This is working well, when set to 1.2, everything works. When set to 1.3, curl fails because (my curl) does not support 1.3.

2021/10/15 11:25:02 http: TLS handshake error from 10.99.1.23:60380: tls: client offered only unsupported versions: [303 302 301]

schmikei
schmikei approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good name fix

@jsirianni jsirianni merged commit 574914f into updated-fields Oct 15, 2021
@jsirianni jsirianni deleted the http-tls-min branch October 15, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmikei schmikei schmikei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirianni @schmikei