go/keymanager/api: Fix key manager client #6078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
peternose
commented
Feb 22, 2025
| @@ -12,8 +12,10 @@ import ( | |||
|
|
|||
| var ( | |||
| // serviceName is the gRPC service name. | |||
| serviceName = cmnGrpc.NewServiceName("KeyManager") | |||
| serviceName = cmnGrpc.NewServiceName("KeyManager.Secrets") | |||
There was a problem hiding this comment.
Is this too breaking? Not sure who even calls this endpoint, since all nodes run consensus 🤔
There was a problem hiding this comment.
Should be fine. Maybe expose both for a few versions and use the new one in clients?
peternose
force-pushed
the
peternose/trivial/fix-km-client
branch
from
5210628 to
c354245
Compare
peternose
force-pushed
the
peternose/trivial/fix-km-client
branch
from
c354245 to
e22cea4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6078 +/- ##
==========================================
+ Coverage 64.86% 65.26% +0.40%
==========================================
Files 636 636
Lines 64641 64729 +88
==========================================
+ Hits 41929 42248 +319
+ Misses 17823 17586 -237
- Partials 4889 4895 +6 ☔ View full report in Codecov by Sentry. |
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving key manager backend from
ServicesBackendtoClientBackend.I also refactored clients, trying to follow these guidelines: