Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate 'zk config' if Lightnet is in use. #579

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Feb 7, 2024

Closes #454
Closes #528


image

image

@shimkiv shimkiv marked this pull request as ready for review February 9, 2024 16:20
@shimkiv shimkiv changed the title (WIP) Automate 'zk config' if Lightnet is in use. Automate 'zk config' if Lightnet is in use. Feb 9, 2024
@shimkiv
Copy link
Member Author

shimkiv commented Feb 9, 2024

Corresponding Nightly run: https://github.com/o1-labs/zkapp-cli/actions/runs/7847361519

Copy link
Collaborator

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm approving this but I had some questions and comments.

@shimkiv shimkiv merged commit 9a5ddb8 into main Feb 13, 2024
12 checks passed
@shimkiv shimkiv deleted the lightnet-zk-config branch February 13, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants