Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightnet sub-commands implementation (start/stop/status). #510
Lightnet sub-commands implementation (start/stop/status). #510
Changes from 4 commits
07b51d6
5af97cf
1b02d87
3e55a3c
4c423f3
8266310
967916a
ba114ef
ac92401
7fff5d6
1404cc4
a2f72ba
711ab32
ce5c6cc
6ffb65e
2b90442
8c921c8
9b9f589
16a1412
c440497
9dff90a
36d97de
1def217
9050aa1
6f87149
ae75be1
0963b73
3f1603d
3ea4eb1
b4142d0
4e8c27f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shimkiv what is the disadvantage of
none
proof-level?none
is default, but does not test other proofs, right? maybe more description to help user choose the appropriate proof level?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the protocol configuration. One of the expensive parts of the protocol is creating blockchain snark proofs, so mocking that is important for faster everything. The
proof_level
Mina constant can be used to disable proving (set it to becheck
) or disable block calculation altogether (set it tonone
).None
is default because for zkApps development with o1js we don't really care about protocol proofs, assuming that it is well tested. Sometimes though one might want to run zkApps against network that has closer to "real world" properties (say, some of the Nightly CI tests). That is whenzk lightnet start --mode multi-node --type real --proof-level full
might be useful.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shimkiv advantages and disadvantages? default is true, so when would we want to use false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker images are updated each night and pulling the new image will takes resources and time should you start the network next day from scratch. It is useful to set
false
when you develop/test zkapp functionality using same version of o1js and Mina dependencies. The reason it is not set tofalse
by default is because I was thinking to encourage people always use "latest and greatest" but not sure already.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default is true, what happens if false? where else would Docker container processes logs be saved? (or not saved at all?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zk lightnet stop
- saves logs from container to host file-system, stops and removes the container.zk lightnet stop --no-save-logs
- stops and removes the container, logs produced by different apps inside the container are gone. Useful for short lived networks when users will just check something zkapp related and don't care about logs.zk lightnet stop --no-save-logs --no-clean-up
- stops the container, it is not removed so container still can be accessible by users in order to get logs manually.