Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change qanet to testnet #253

Merged
merged 1 commit into from
Sep 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,18 +134,17 @@ configurations.
Run the `zk config` command to add a new deployment configuration to this file.

This command is interactive and will prompt you to specify 1.) a network name
(can be anything, e.g. `qanet`), 2.) the Mina GraphQL API URL where you want to
(can be anything, e.g. `testnet`), 2.) the Mina GraphQL API URL where you want to
send your deployment transaction (e.g.
`https://proxy.berkeley.minaexplorer.com/graphql`), and 3.) the transaction fee
to be used during deployment (in MINA; e.g. `0.01`). The URL is significant
because this determines which network you're deploying to (e.g. `QANet`,
`Testnet`, etc).

Note: If your project contains more than one smart contract that you will be
deploying, we recommend following an alias naming convention such as `qanet-foo`
and `qanet-bar`, where `qanet` is the name of the network and `foo` and `bar`
are the name of your smart contracts. Then you can deploy using `zk deploy
qanet-foo` and `zk deploy qanet-bar`.
deploying, we recommend following an alias naming convention such as `testnet-foo`
and `testnet-bar`, where `testnet` is the name of the network and `foo` and `bar`
are the name of your smart contracts. Then you can deploy using `zk deploy testnet-foo` and `zk deploy testnet-bar`.

### Deploy your smart contract

Expand All @@ -155,18 +154,16 @@ zk deploy <alias>
zk deploy // will show a list of aliases in your project to choose from
```

_**Deployment is possible to Berkeley QANet currently and--soon--will
be possible for Berkeley Testnet. It is not possible to deploy
_**Deployment is possible to Berkeley Testnet currently. It is not possible to deploy
to Mina Mainnet at this time.**_

The `deploy` command allows you to deploy a smart contract to your desired
alias. You must run `zk config` once before deploying, in order to set up a
deploy alias with the required details. Then run `zk deploy <alias>` or `zk
deploy` (and select the alias from the list shown) and type `yes` or `y` to
deploy alias with the required details. Then run `zk deploy <alias>` or `zk deploy` (and select the alias from the list shown) and type `yes` or `y` to
confirm when prompted.

Note: When deploying to an alias for the first time, the CLI will prompt you to
choose which smart contract you want to deploy from those that exist as *named*
choose which smart contract you want to deploy from those that exist as _named_
exports in your project. The name of the smart contract that you choose will
then be remembered by being saved into your `config.json` for this alias, so
that running `zk deploy <alias>` will automatically deploy this _same_ smart
Expand All @@ -176,8 +173,7 @@ contract in the future when deploying to this alias, for safety.

The best way to contribute to the zkApp CLI is to help us test it broadly to
ensure it works as expected on all platforms. If you encounter any issues,
please submit an issue on Github and include the info printed when running `zk
system`, which contains your OS, NodeJS, & zkapp-cli versions to help us
please submit an issue on Github and include the info printed when running `zk system`, which contains your OS, NodeJS, & zkapp-cli versions to help us
reproduce the issue.

To submit a PR:
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "zkapp-cli",
"version": "0.4.15",
"version": "0.4.16",
"description": "CLI to create a zkApp (\"zero-knowledge app\") for Mina Protocol.",
"keywords": [
"cli",
Expand Down
2 changes: 1 addition & 1 deletion src/lib/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ async function config() {
const str =
`\nSuccess!\n` +
`\nNext steps:` +
`\n - If this is a testnet, request tMINA at:\n https://faucet.minaprotocol.com/qanets?address=${encodeURIComponent(
`\n - If this is a testnet, request tMINA at:\n https://faucet.minaprotocol.com/?address=${encodeURIComponent(
keyPair.publicKey
)}` +
`\n - To deploy, run: \`zk deploy ${network}\``;
Expand Down