Build fix for lagrange basis performance #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivo25
reviewed
Oct 21, 2024
| return new Field(0); | ||
| }, | ||
| }, | ||
| run: { |
There was a problem hiding this comment.
Any specific reason for two methods here? Are they required for the test? Just curious
There was a problem hiding this comment.
The LB is only calculated for a "recursive" proof. The pattern I know is a base case and a recursive case. Can we pass a proof as input and only use 1 method?
There was a problem hiding this comment.
We should be able to. But that's fine, I was just wondering
Trivo25
approved these changes
Oct 21, 2024
| return new Field(0); | ||
| }, | ||
| }, | ||
| run: { |
There was a problem hiding this comment.
We should be able to. But that's fine, I was just wondering
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1869
This PR mainly bundles Gregor's changes from MinaProtocol/mina#16261
I also added a unit test to confirm that the filesystem cache is being accessed by typescript, which is a proxy for the bug being fixed. The performance bug was originally introduced in #1857 which was also a bugfix. This branch includes unit tests for each bug, and both are passing.