Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[berkeley] Expose lookup commitments #122

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Aug 22, 2023

Waiting for MinaProtocol/mina#13899 to be merged to continue.
FIx MinaProtocol/mina#13909
Depends on o1-labs/o1js#1089

  • Regenerate bindings when 13899 is merged.. Artefacts are built on top of it.

@dannywillems dannywillems requested a review from a team as a code owner August 22, 2023 09:00
@dannywillems dannywillems force-pushed the dannywillems/expose-lookup-commitmens-berkeley branch 2 times, most recently from 55c7844 to be5a594 Compare August 23, 2023 14:37
@dannywillems dannywillems force-pushed the dannywillems/expose-lookup-commitmens-berkeley branch from be5a594 to 35e90ed Compare August 23, 2023 15:29
@dannywillems dannywillems force-pushed the dannywillems/expose-lookup-commitmens-berkeley branch from 35e90ed to b028028 Compare August 23, 2023 15:31
@dannywillems dannywillems force-pushed the dannywillems/expose-lookup-commitmens-berkeley branch from b028028 to 3f542c5 Compare August 23, 2023 15:49
Copy link
Contributor

@rbonichon rbonichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only have very minor improvements

@dannywillems dannywillems merged commit 17e2f4f into berkeley Aug 24, 2023
@dannywillems dannywillems deleted the dannywillems/expose-lookup-commitmens-berkeley branch August 24, 2023 10:13
@dannywillems
Copy link
Member Author

Opened follow-up issue here regarding @rbonichon comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants