This repository was archived by the owner on Aug 17, 2023. It is now read-only.
forked from jessemiller/HamlPy
-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to access options in different classes
It would be great to find a way to throw a depreciation warning if we find that the old syntax is still used instead of disabling it by default and breaking on a "pip -U". I don't know if it's a lot of work :/ |
@Psycojoker agreed but this PR doesn't disable it by default - this PR is completely backwards compatible |
Oh, my bad, shouldn't review tired after work, sorry :/ |
Np. Did you actually get a chance to look at the code? Would really love to get this merged as we need this to use the latest django-hamlpy with our main project. |
@Psycojoker bump. I don't like to pester but this PR has been open almost two weeks and we need it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR punts on the question of deprecating
={...}
for now, and just makes it optional using theHAMLPY_DJANGO_INLINE_STYLE
setting.I still think deprecation is the way to go, especially once we add support for
.(attr=val)
syntax which introduces yet another meaning for=
. I just want more time to think through the path to becoming more HAML and less HAMLPY. It bothers me that we'll be supporting three different syntaxes for attributes (.{attr:val}
,.{attr=>val}
and.(attr=val)
) but dropping support for syntax that people are using is always tricky.Addresses #16. @Psycojoker please review