Skip to content
This repository was archived by the owner on Aug 17, 2023. It is now read-only.

Python 3 support #1

Merged
merged 18 commits into from
Oct 13, 2016
Merged

Python 3 support #1

merged 18 commits into from
Oct 13, 2016

Conversation

rowanseymour
Copy link
Member

No description provided.

@Psycojoker
Copy link
Collaborator

Thanks for your work :)

Don't hesitate to modify the .travis-ci.yml to include other version of python in the CI build.

@rowanseymour
Copy link
Member Author

I've added tox to test against Python 2.7 and 3.4.

Two of the tests for 3.4 are failing because of #2

@@ -0,0 +1,2 @@
include LICENSE
include readme.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensures readme is in dist as it's required by setup

@rowanseymour
Copy link
Member Author

@Psycojoker I've merged in #3 so tests pass now. Ready for review.

@Psycojoker
Copy link
Collaborator

Psycojoker commented Oct 12, 2016

Great, will try to do that pretty fast :) (I'm at work right now and this isn't our current focus)

And thanks again!

Copy link
Collaborator

@Psycojoker Psycojoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from this missing dependency everything seems fine and is running in my situations.

It might be worth it to add a few line in readme.md regarding the availability of tox to run tests.

import re
import six
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Six seems to be missing from setup.py and from the requirements file.

This apparently come from the fact that mock pulls it for testing.

@rowanseymour
Copy link
Member Author

I've added six as a requirement. I've got a few suggested changes to the readme.md - can I put those in a subsequent PR ?

@Psycojoker
Copy link
Collaborator

I've got a few suggested changes to the readme.md - can I put those in a subsequent PR ?

Yup :)

Do you think that this code is ready for release of would you prefer to wait a bit before?

Thanks again for your work!

@Psycojoker Psycojoker merged commit 57d21b3 into nyaruka:master Oct 13, 2016
@rowanseymour rowanseymour deleted the python3 branch October 13, 2016 14:21
@rowanseymour
Copy link
Member Author

I think it is. The only way we're going to find Python 3 issues is to start using it! In fact I'd appreciate a PyPI release before we merge the attribute parser stuff because I'm less confident about it - it's a lot of changes.

I'd suggest bumping the minor version so this is the 0.9.0 release.

@Psycojoker
Copy link
Collaborator

I'd appreciate a PyPI release before we merge the attribute parser stuff

And that's done :) https://pypi.python.org/pypi/django-hamlpy/0.85

I'd suggest bumping the minor version so this is the 0.9.0 release.

Actually, we are at number "85" and not "8", jesse seems to have done a lot of releases.

@rowanseymour
Copy link
Member Author

Oh yeah we are. Weird. Thanks for the release!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants