-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
Thanks for your work :) Don't hesitate to modify the .travis-ci.yml to include other version of python in the CI build. |
I've added tox to test against Python 2.7 and 3.4. Two of the tests for 3.4 are failing because of #2 |
@@ -0,0 +1,2 @@ | |||
include LICENSE | |||
include readme.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensures readme is in dist as it's required by setup
@Psycojoker I've merged in #3 so tests pass now. Ready for review. |
Great, will try to do that pretty fast :) (I'm at work right now and this isn't our current focus) And thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appart from this missing dependency everything seems fine and is running in my situations.
It might be worth it to add a few line in readme.md
regarding the availability of tox to run tests.
import re | ||
import six |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Six seems to be missing from setup.py
and from the requirements
file.
This apparently come from the fact that mock
pulls it for testing.
I've added six as a requirement. I've got a few suggested changes to the readme.md - can I put those in a subsequent PR ? |
Yup :) Do you think that this code is ready for release of would you prefer to wait a bit before? Thanks again for your work! |
I think it is. The only way we're going to find Python 3 issues is to start using it! In fact I'd appreciate a PyPI release before we merge the attribute parser stuff because I'm less confident about it - it's a lot of changes. I'd suggest bumping the minor version so this is the 0.9.0 release. |
And that's done :) https://pypi.python.org/pypi/django-hamlpy/0.85
Actually, we are at number "85" and not "8", jesse seems to have done a lot of releases. |
Oh yeah we are. Weird. Thanks for the release! |
No description provided.