rebuild CodeNarcServer.jar #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
|
Replaced by #313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
CodeNarcServer.jarcompiled againstCodeNarcServer.groovycommit 062564c . The previous jar looks like it built using a different, unknown version ofCodeNarcServer.groovythan what is published.This compile used
Also re-enable the skipped tests for openjdk/windows.
The tests are passing for the Linux platforms, although they sometimes fail in GH actions (timeout waiting on CN server). I can not reproduce these timeouts in local containers. Tests usually pass when re-running the GH action tests.
macOS and windows tests still timeout in the GH actions. I don't have a easy way to troubleshoot that locally.
This is an incomplete solution so I don't expect this PR to get merged. It's more a proof of concept to remove some of the test blockers.