fix: split from buffer view opens blank buffer (#898) #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cseickel
approved these changes
Jun 21, 2023
|
Hey @cseickel, this is broken. See the review I added above inside the code. |
|
@pysan3 I don't see any review or comments, an you link to them and/or repeat them here? |
|
Sorry that I don't know how to link a review but it's this
|
|
Oh I see, your review is still pending @pysan3, no one else can see it until you submit it. |
|
I'll fix it. |
pysan3
reviewed
Jun 21, 2023
| @@ -551,13 +551,14 @@ end | |||
| ---@param bufnr number|nil The buffer number to open | |||
| M.open_file = function(state, path, open_cmd, bufnr) | |||
| open_cmd = open_cmd or "edit" | |||
| if open_cmd == "edit" or open_cmd == "e" then | |||
| local cmd_for_buf = { edit = "b", e = "b", split = "sb", sp = "sb" } | |||
| if open_cmd[cmd_for_buf] ~= nil then | |||
There was a problem hiding this comment.
Should be if cmd_for_buf[open_cmd] ....
It's the other way around.
|
Damn, this was my first time to use I think I was able to figure it out? Can you see it now? |
This was referenced Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in buffer view, where a blank buffer would open instead of the selected buffer when using the
open_splitshortcut.More details on #898