Skip to content

Commit

Permalink
NVDAObjects/UIA/search field: EdgeHTML Edge's address omnibar is no l…
Browse files Browse the repository at this point in the history
…onger a search field. Re #10002. (#10200)

Thanks to UIA auto-select for eit fields, it is no longer necessary to treat Edge's address omnibar as a dedicated search field, in that search results will be announced automatically. This also resolves an issue where NVDA kept playing search suggestion sound when Edge was maximized due to odd controller for event being fired by omnibar itself.
  • Loading branch information
josephsl authored and michaelDCurran committed Sep 13, 2019
1 parent b9c81a5 commit 3f14ddd
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions source/NVDAObjects/UIA/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -863,8 +863,7 @@ def findOverlayClasses(self,clsList):
if isDialog:
clsList.append(Dialog)
# #6241: Try detecting all possible suggestions containers and search fields scattered throughout Windows 10.
# In Windows 10, allow Start menu search box and Edge's address omnibar to participate in announcing appearance of auto-suggestions.
if self.UIAElement.cachedAutomationID in ("SearchTextBox", "TextBox", "addressEditBox"):
if self.UIAElement.cachedAutomationID in ("SearchTextBox", "TextBox"):
clsList.append(SearchField)
try:
# Nested block here in order to catch value error and variable binding error when attempting to access automation ID for invalid elements.
Expand Down

0 comments on commit 3f14ddd

Please sign in to comment.