Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case where TestCaseSource and no CancellationToken parameter #686

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix case where TestCaseSource and no CancellationToken parameter #686

merged 1 commit into from
Jan 30, 2024

Conversation

manfred-brands
Copy link
Member

Fixes #685

katzenbier
katzenbier approved these changes Jan 30, 2024
View reviewed changes
Copy link

@katzenbier katzenbier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this locally, and it fixed the issue.

mikkelbu
mikkelbu approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @manfred-brands

@mikkelbu mikkelbu merged commit 16f640e into nunit:master Jan 30, 2024
6 checks passed
@mikkelbu mikkelbu added this to the Release 4.1 milestone Jan 30, 2024
@manfred-brands manfred-brands deleted the issue685_TestCaseSource branch August 9, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

@katzenbier katzenbier katzenbier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 4.0.1
Development

Successfully merging this pull request may close these issues.

error NUnit1029: The TestCaseSource provides '1' parameter(s), but the Test method expects '1' parameter(s)
3 participants
@manfred-brands @mikkelbu @katzenbier